Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GSLS optimizer bounds if entries have None #95

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix GSLS optimizer bounds if entries have None #95

merged 1 commit into from
Oct 30, 2023

Conversation

woodsp-ibm
Copy link
Member

Summary

Fixes #94

Details and comments

When the optimizer creates its upper and lower bound arrays, any None entrys are replaced by infinity (i.e. No bound)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6618976410

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 90.554%

Totals Coverage Status
Change from base Build 6573888143: 0.03%
Covered Lines: 6452
Relevant Lines: 7125

💛 - Coveralls

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ElePT ElePT merged commit b254504 into qiskit-community:main Oct 30, 2023
13 checks passed
@woodsp-ibm woodsp-ibm deleted the gsls_bounds branch October 30, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GSLS optimizer crashing with QAOA default parameter bounds
3 participants