Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qiskit 1.0 compatibility] fake backends moved to qiskit-ibm-runtime #70

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

1ucian0
Copy link
Contributor

@1ucian0 1ucian0 commented Feb 15, 2024

As part of getting ready for Qiskit 1.0, mapomatic needs to move away from the fake providers in Qiskit to those in qiskit-ibm-runtime.

It also includes a port for Qiskit/qiskit-addon-mthree#199

Copy link
Collaborator

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not clear why the pylint changes are necessary. But it doesn't hurt anything and pinning pylint is good practice to avoid spurious changes to the rules being enforced

@@ -1,4 +1,5 @@
pytest
pylint
pylint==2.16.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to pin pylint here normally we will need to pin astroid. If the two package get out of sync things can get weird. But looking at the pylint requirements and astroid releases I think in practice this will be pinned to astroid 2.15.8 because of the upper bound on pylint's requirements and the project having moved on. So I think this is fine.

@mtreinish mtreinish merged commit 8f1946d into qiskit-community:main Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants