-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tas 247 #520
Open
jjmartinezQT
wants to merge
99
commits into
main
Choose a base branch
from
feature/TAS-247
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/tas 247 #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Albert Mitjans <[email protected]>
…m/qilimanjaro-tech/qililab into feature/instruments_initial_setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch brings the possibility to use the new_drivers flag to work with a version of the platform that uses the new drivers and buses, along a new runcard format.
SLACK COMMENT JUANJO:
En esta se añade la funcionalidad de la flag new_drivers en platform, de manera que platform use los nuevos instrumentos y buses si la flag esta seteada a True
He creado una clase llamada NewRuncard, porque la nueva runcard no tiene instrument controller y los drivers cambian un poco. Cuando tengas tu PR lista Guille, hay que meter la representación de los buses en esa clase, de manera que refleje el tipo de buses nuevos.
Aparte de eso queda completar los unittests de test_platform, que sólo he llegado hasta el de build_plaform usando la flag de new_drivers. Lo ideal sería crear otra fixture, a ser posible que lea de un fichero yaml, no de data.py, pero como hemos hablado esa es la última prioridad.