Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tas 247 #520

Open
wants to merge 99 commits into
base: main
Choose a base branch
from
Open

Feature/tas 247 #520

wants to merge 99 commits into from

Conversation

jjmartinezQT
Copy link
Collaborator

@jjmartinezQT jjmartinezQT commented Aug 24, 2023

This branch brings the possibility to use the new_drivers flag to work with a version of the platform that uses the new drivers and buses, along a new runcard format.

  • Taking testing data for new runcard out of data.py and into a yaml file.
  • Complete test_platform.py for platform using new_drivers, parametrize both platforms as fixtures?

SLACK COMMENT JUANJO:

En esta se añade la funcionalidad de la flag new_drivers en platform, de manera que platform use los nuevos instrumentos y buses si la flag esta seteada a True

He creado una clase llamada NewRuncard, porque la nueva runcard no tiene instrument controller y los drivers cambian un poco. Cuando tengas tu PR lista Guille, hay que meter la representación de los buses en esa clase, de manera que refleje el tipo de buses nuevos.

Aparte de eso queda completar los unittests de test_platform, que sólo he llegado hasta el de build_plaform usando la flag de new_drivers. Lo ideal sería crear otra fixture, a ser posible que lea de un fichero yaml, no de data.py, pero como hemos hablado esa es la última prioridad.

@jjmartinezQT jjmartinezQT self-assigned this Aug 25, 2023
@notion-workspace
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant