Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/instruments initial setup #519

Open
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

jjmartinezQT
Copy link
Collaborator

@jjmartinezQT jjmartinezQT commented Aug 23, 2023

This branch brings the ability to separate creating the instance of an instrument, using the new drivers, from the initial setup of parameters.

@jjmartinezQT jjmartinezQT marked this pull request as draft August 23, 2023 06:57
Copy link
Contributor

@AlbertMitjans AlbertMitjans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments!

src/qililab/drivers/instruments/instruments.py Outdated Show resolved Hide resolved
src/qililab/drivers/instruments/instruments.py Outdated Show resolved Hide resolved
src/qililab/drivers/instruments/qblox/pulsar.py Outdated Show resolved Hide resolved
src/qililab/drivers/instruments/qblox/pulsar.py Outdated Show resolved Hide resolved
src/qililab/drivers/instruments/qblox/pulsar.py Outdated Show resolved Hide resolved
src/qililab/drivers/instruments/qblox/sequencer_qrm.py Outdated Show resolved Hide resolved
src/qililab/drivers/interfaces/base_instrument.py Outdated Show resolved Hide resolved
tests/data.py Outdated Show resolved Hide resolved
src/qililab/platform/platform.py Outdated Show resolved Hide resolved
src/qililab/platform/platform.py Outdated Show resolved Hide resolved
@jjmartinezQT jjmartinezQT marked this pull request as ready for review August 23, 2023 15:44
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #519 (c0acf85) into main (78ca2d2) will decrease coverage by 1.11%.
Report is 1 commits behind head on main.
The diff coverage is 46.38%.

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   96.39%   95.29%   -1.11%     
==========================================
  Files         274      274              
  Lines        7295     7417     +122     
==========================================
+ Hits         7032     7068      +36     
- Misses        263      349      +86     
Flag Coverage Δ
unittests 95.29% <46.38%> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/qililab/drivers/instruments/qblox/spi_rack.py 73.58% <15.15%> (-26.42%) ⬇️
src/qililab/drivers/interfaces/base_instrument.py 72.00% <41.66%> (-28.00%) ⬇️
src/qililab/drivers/instruments/qblox/pulsar.py 68.08% <48.27%> (-31.92%) ⬇️
src/qililab/drivers/instruments/qblox/cluster.py 74.83% <53.57%> (-25.17%) ⬇️
src/qililab/constants.py 100.00% <100.00%> (ø)
src/qililab/drivers/__init__.py 100.00% <100.00%> (ø)
...ilab/drivers/instruments/keithley/keithley_2600.py 100.00% <100.00%> (ø)
...qililab/drivers/instruments/qblox/sequencer_qcm.py 100.00% <100.00%> (ø)
...qililab/drivers/instruments/qblox/sequencer_qrm.py 100.00% <100.00%> (ø)
...lab/drivers/instruments/yokogawa/yokogawa_gs200.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

@notion-workspace
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants