depend on numpy 1.13.3 instead of 1.13.0 #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy 1.13.0 seems to be gone from conda channels
install qiita_client before patching the source
|
Sorry @sjanssen2, I just saw this PR and I should have pull these changes first before pushing #71. Anyway, I pulled the changes here to that PR and I'm going to continue working on that one to make the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a local Qiita setup, I have had issues with installing the qp-deblur plugin, more specifically with creating of the given conda environment, i.e. the one stated here
qp-deblur/.github/workflows/qiita-plugin-ci.yml
Line 82 in efd59e3
Looks like numpy 1.13.0 is no longer offered through conda channels. I was able to change to 1.13.3 but had to adapt some more parts like cython install through pip once conda environment is set ...
These changes work OK for my local install, but I do see that tests in github actions fail. I thus also tried to update relatively old github action instructions with those from qp-woltka, e.g. migrate to postgress 13, but I now encounter SSL certificate issues.
Question to @antgonza and the qiita team: Is this due to a missing github secret or other misconfiguration problems within the control of the action yaml?!
FYI: triggering re-execution of the current test workflow fails as in PR #70 :-/