Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade qblox-instruments dependency #859

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Upgrade qblox-instruments dependency #859

merged 8 commits into from
Apr 16, 2024

Conversation

hay-k
Copy link
Contributor

@hay-k hay-k commented Mar 28, 2024

As a side effect of investigating #845 I had to upgrade the firmware on the instruments in our lab, which in turn means updating the qblox-instruments dependency. This PR contains only changes related to this upgrade.

P.S. This upgrade does not fix the issue. The fix is expected to come with another firmware upgrade in future.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 66.59%. Comparing base (3144c1d) to head (62a816b).
Report is 2 commits behind head on main.

Files Patch % Lines
src/qibolab/instruments/qblox/cluster_qrm_rf.py 55.55% 4 Missing ⚠️
src/qibolab/instruments/qblox/cluster_qcm_bb.py 71.42% 2 Missing ⚠️
src/qibolab/instruments/qblox/cluster_qcm_rf.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
+ Coverage   66.57%   66.59%   +0.01%     
==========================================
  Files          55       55              
  Lines        5939     5942       +3     
==========================================
+ Hits         3954     3957       +3     
  Misses       1985     1985              
Flag Coverage Δ
unittests 66.59% <65.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hay-k hay-k force-pushed the qblox-timeout branch 5 times, most recently from 9cad14c to 7dcd9b8 Compare April 3, 2024 13:33
@hay-k hay-k changed the title Qblox timeout Upgrade to latest qblox Apr 3, 2024
@hay-k hay-k changed the title Upgrade to latest qblox Qblox timeout Apr 3, 2024
@hay-k hay-k changed the title Qblox timeout Upgrade qblox-instruments dependency Apr 15, 2024
@hay-k hay-k marked this pull request as ready for review April 16, 2024 06:29
@hay-k hay-k requested review from alecandido and stavros11 April 16, 2024 06:29
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hay-k.

Regarding the QPU tests, I think there is something wrong with the label workflow. If you run them manually

srun -p spinq10q pytest -m qpu --platform spinq10q --no-cov

they are passing, except one failure related to a transpiler/compiler issue, which I caused and is unrelated to this PR.

@hay-k hay-k merged commit a514441 into main Apr 16, 2024
24 of 26 checks passed
@stavros11 stavros11 deleted the qblox-timeout branch April 16, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants