-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade qblox-instruments dependency #859
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
==========================================
+ Coverage 66.57% 66.59% +0.01%
==========================================
Files 55 55
Lines 5939 5942 +3
==========================================
+ Hits 3954 3957 +3
Misses 1985 1985
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9cad14c
to
7dcd9b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hay-k.
Regarding the QPU tests, I think there is something wrong with the label workflow. If you run them manually
srun -p spinq10q pytest -m qpu --platform spinq10q --no-cov
they are passing, except one failure related to a transpiler/compiler issue, which I caused and is unrelated to this PR.
As a side effect of investigating #845 I had to upgrade the firmware on the instruments in our lab, which in turn means updating the
qblox-instruments
dependency. This PR contains only changes related to this upgrade.P.S. This upgrade does not fix the issue. The fix is expected to come with another firmware upgrade in future.
Checklist: