Use triggered mode for QM local oscillators #856
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
==========================================
+ Coverage 66.66% 66.75% +0.08%
==========================================
Files 55 55
Lines 5901 5916 +15
==========================================
+ Hits 3934 3949 +15
Misses 1967 1967
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/qibolab/instruments/qm/ports.py
Outdated
| DIGITAL_PULSE_CALIBRATION = {"delay": 57, "buffer": 18} | ||
| """Calibration of digital pulses used for LO triggering. | ||
|
|
||
| https://docs.quantum-machines.co/1.1.7/qm-qua-sdk/docs/Guides/octave/#calibrating-the-digital-pulse | ||
| """ |
There was a problem hiding this comment.
Shouldn't this be part of the instrument settings?
There was a problem hiding this comment.
In principle yes, but given that it is very instrument related (I don't think we are using digital pulses with any other instrument, I am not sure if they even support them) and therefore we are not going to calibrate it, at least using qibocal, I would hide it from the runcard to not confuse users. If I put it in the settings, qibocal will dump it automatically in the runcard.
As an intermediate solution, in 9e2a7b4 I moved it to port fields, so that at least it is possible to modify it when creating the platform (but in the create not the runcard).
We found that using the
always_onmode leaves the LOs on even after execution. This may cause issues related to LO leakage, if the mixers are not calibrated and the LO gain is very high.Using the
triggeredmode allows the LO signal to pass only when something is playing in the corresponding port, by sending a simultaneous digital trigger.I have done some quick tests with qw5q_platinum and this seems to maintain results. I have not confirmed whether the LOs are really turned off.