ToF routine for qblox #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 64.00% 64.03% +0.03%
==========================================
Files 49 49
Lines 5778 5778
==========================================
+ Hits 3698 3700 +2
+ Misses 2080 2078 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alecandido
approved these changes
Jan 17, 2024
alecandido
reviewed
Jan 17, 2024
stavros11
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Thanks @PiergiorgioButtarini. If you can merge main and fix the conflicts and the comments above, we can probably merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce the possibility of retrieving
AcquisitionType.RAWresults for Qblox.This type acquisition was used to produce the following ToF routine (using qibocal branch qiboteam/qibocal#679): http://login.qrccluster.com:9000/whJVmwwASf2x5tnTU534Dw==
Note:
To be more precise, at the moment these results are automatically (by the module itself) averaged on the
nshotdimension.So for example the raw plot made with
nshots=1000will be the average of the 1000 different raw plots.Since this averaging is happening automatically (there is only one memory for
scope_acquisition, but maybe this can be changed assigning different sequencers other than the default one) is not possible to retrieve raw results for more than one measurement process per channel.In fact two measurement in series (one after the other) will be stored and at the and averaged together, producing meaningless results.
Checklist: