Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting coupler_flux sequence into multiple sub sections #723

Merged
merged 10 commits into from
Jan 16, 2024

Conversation

GabrielePalazzo
Copy link
Contributor

Closes #722.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (56bf837) 62.58% compared to head (545a865) 62.57%.
Report is 79 commits behind head on main.

Files Patch % Lines
src/qibolab/instruments/zhinst.py 94.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   62.58%   62.57%   -0.02%     
==========================================
  Files          48       48              
  Lines        6644     6642       -2     
==========================================
- Hits         4158     4156       -2     
  Misses       2486     2486              
Flag Coverage Δ
unittests 62.57% <94.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabrielePalazzo GabrielePalazzo marked this pull request as ready for review December 20, 2023 12:15
@GabrielePalazzo GabrielePalazzo requested a review from hay-k January 10, 2024 09:37
@hay-k
Copy link
Contributor

hay-k commented Jan 11, 2024

In general, there is a lot of duplication of code in the ZI driver, and this is another example of it. E.g. similar logic for handling subsequences and delays between pulses exists for qubit drive and qubit flux as well. This is not your fault and should not be addressed in this PR. Everything else is done like this in the driver so to fix the bug you are kind of forced to do it like this as well, because otherwise you will need to rewrite half of the driver :D. I just wanted to point this out and emphasize that we need to address it ASAP. I will be taking care of that, so no action point for you, just FYI.

Copy link
Contributor

@Jacfomg Jacfomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it now, seems to solve the issues in #722. About the code duplication @hay-k that comes from me, so I can try to help with that as well.

@GabrielePalazzo GabrielePalazzo merged commit 7056c84 into main Jan 16, 2024
21 checks passed
@GabrielePalazzo GabrielePalazzo deleted the zh_couplerflux_subsection branch January 16, 2024 12:59
@alecandido alecandido added this to the Qibolab 0.1.5 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When playing coupler_flux pulses play_after is incorrect
5 participants