-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting coupler_flux sequence into multiple sub sections #723
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
==========================================
- Coverage 62.58% 62.57% -0.02%
==========================================
Files 48 48
Lines 6644 6642 -2
==========================================
- Hits 4158 4156 -2
Misses 2486 2486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In general, there is a lot of duplication of code in the ZI driver, and this is another example of it. E.g. similar logic for handling subsequences and delays between pulses exists for qubit drive and qubit flux as well. This is not your fault and should not be addressed in this PR. Everything else is done like this in the driver so to fix the bug you are kind of forced to do it like this as well, because otherwise you will need to rewrite half of the driver :D. I just wanted to point this out and emphasize that we need to address it ASAP. I will be taking care of that, so no action point for you, just FYI. |
Co-authored-by: Hayk Sargsyan <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Hayk Sargsyan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #722.
Checklist: