Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ansatzes and example scripts #82

Merged
merged 36 commits into from
Jan 8, 2025
Merged

More ansatzes and example scripts #82

merged 36 commits into from
Jan 8, 2025

Conversation

chmwzc
Copy link
Contributor

@chmwzc chmwzc commented Feb 16, 2024

Summary

This pull request aims to (eventually) implement two additional VQE circuit ansatzes for chemistry using Qibo.
In addition, sample scripts examining the use of the Parameter Shift Rule implemented in Qibo for chemistry applications with these ansatzes (Currently in: psr_*.py) will be added to the /examples folder.

Reference papers:

  1. paper2.py: https://doi.org/10.1038/s41534-019-0240-1
  2. paper3-*.py: https://doi.org/10.22331/q-2022-06-20-742

Task List:

  • Circuit ansatzes:
    • Finish and check the code for the circuit ansatzes
    • Migrate finished code to /ansatz
    • Documentation
    • Tests
  • PSR example:
    • Cleanup scripts after first part done
    • Add examples to documentation

Acknowledgements

The original drafts of these scripts, in the form of Jupyter notebooks, was prepared by Caleb Seow and Sng Yi Xin from Eunoia Junior College, and Conan Tan from National Junior College.
The students were attached to IHPC in December 2023 under the A*STAR Research Attachment Programme for Junior College students.

No paper1.py?

For the interested, there were supposed to be three ansatzes; one for each student.
The code for the last circuit ansatz, by Yordanov et al. (link here) wasn't finished within their attachment period, which is why there's no paper1.py here.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7d34af4) to head (c4ef7d3).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #82    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           13        16     +3     
  Lines          641       751   +110     
==========================================
+ Hits           641       751   +110     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chmwzc chmwzc self-assigned this Feb 16, 2024
@chmwzc chmwzc added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 16, 2024
@yjmaxpayne
Copy link
Contributor

yjmaxpayne commented Feb 16, 2024

Hi Zicheng, please remember to incorporate the acknowledgement in the future sphinx Doc as well. Thanks.

@scarrazza scarrazza added this to the Qibochem 0.0.4 milestone May 27, 2024
@chmwzc chmwzc marked this pull request as ready for review September 13, 2024 03:02
@damarkian
Copy link
Contributor

I was wondering if the students have their own GitHub accounts? If so, it would be nice to have them do a commit of some form here, and have ownership in the qibochem zenodo.

@chmwzc
Copy link
Contributor Author

chmwzc commented Nov 12, 2024

I don't think they can commit directly into this repository - they need to be added to the qiboteam team right?
Alternatively, I think I'll add on or edit a page in the documentation for this, seems like a simpler solution?

@damarkian damarkian merged commit 1aa6f4a into main Jan 8, 2025
19 checks passed
@damarkian damarkian deleted the dec2023rap branch January 8, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants