Skip to content

Commit

Permalink
A "safer" workround for AMD ZEN Microphone
Browse files Browse the repository at this point in the history 
Previously the workround is to disable DMA Position Buffer Enable bit
completely, which can be dangerous.
This new patch just skips that bit check in
getAudioStreamLinkPositionInDMABuffer method, which can be "safer".
  • Loading branch information
@qhuyduong
qhuyduong committed Aug 29, 2023
1 parent 84bccd4 commit b071754
Showing 1 changed file with 22 additions and 2 deletions.
24 changes: 22 additions & 2 deletions Resources/Controllers.plist
View file
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,16 @@
<key>Replace</key>
<data>DCBmNSIQdAQxwP/I</data>
</dict>
<dict>
<key>Count</key>
<integer>1</integer>
<key>Find</key>
<data>9sIBdQ0=</data>
<key>Name</key>
<string>AppleHDAController</string>
<key>Replace</key>
<data>9sIBkJA=</data>
</dict>
</array>
<key>Vendor</key>
<string>AMDZEN</string>
Expand Down Expand Up @@ -512,6 +522,16 @@
<key>Replace</key>
<data>DCBmNSIQdAQxwP/I</data>
</dict>
<dict>
<key>Count</key>
<integer>1</integer>
<key>Find</key>
<data>9sIBdQ0=</data>
<key>Name</key>
<string>AppleHDAController</string>
<key>Replace</key>
<data>9sIBkJA=</data>
</dict>
</array>
<key>Vendor</key>
<string>AMDZEN</string>
Expand Down Expand Up @@ -557,11 +577,11 @@
<key>Count</key>
<integer>1</integer>
<key>Find</key>
<data>g34MAHVh</data>
<data>9sIBdQ0=</data>
<key>Name</key>
<string>AppleHDAController</string>
<key>Replace</key>
<data>g34MAOth</data>
<data>9sIBkJA=</data>
</dict>
</array>
<key>Vendor</key>
Expand Down

5 comments on commit b071754

@herrnst
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

any plans and/or any chance to upstream these changes so that ie. Ryzen Laptops can profit from a working built-in microphone with vanilla AppleALC?

Thanks!

@radianttap
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second @herrnst comment.

This patch enabled back mic-in port on my 5900X + B550I Aorus AX Pro build. It's rather noisy signal but it does work.

@CaseySJ
Copy link

@CaseySJ CaseySJ commented on b071754 Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Have you considered issuing a Pull Request to Acidanthera so this fix can become part of the standard AppleALC?

This fixes microphone input on my Gigabyte B550 Vision D.

@qhuyduong
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys,

I have just created the PR. Let just wait for Acidanthera's answer.
acidanthera#882

@herrnst
Copy link

@herrnst herrnst commented on b071754 Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi guys,

I have just created the PR. Let just wait for Acidanthera's answer. acidanthera#882

Thanks alot for this, very much appreciated!

Please sign in to comment.