-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual point clouds overview in 2D #59854
base: master
Are you sure you want to change the base?
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I have an objection on the need for those averageSubIndexWidth and averageSubIndexHeight methods, though.
This will need some unit tests added too 👍 |
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
@Withalion A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
Load overview if it exists either by ref from vpc file or look for overview file. Render overview instead of extends by default when zoomed out.
537833f
to
77c1191
Compare
77c1191
to
c28b8de
Compare
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Description
This PR changes the default behaviour of VPC rendering. We switch from rendering extents when zoomed out to rendering overview when it's present. This change adds seamless transition between overview into specific point clouds. Furthermore the user is able to switch between just extents, just overview and extents rendered over overview, by using combo box in layer styling side panel.
Screencast_20241212_142233.mp4
The label settings were also moved together with zoom out behaviour settings into new Virtual point cloud options
QgsCollapsibleGroupBox
. Which is visible only when dealing with virtual point clouds styling.Note: When I dealt with setting the default
Qgis::PointCloudZoomOutBehavior
for layer renderer I noticed that the renderer is actually created multiple times!QgsPointCloudLayer::setDataSourcePrivate
, which is called by constructorQGIS/src/core/pointcloud/qgspointcloudlayer.cpp
Lines 467 to 487 in fb501d5
QgsAppLayerHandling::postProcessAddedLayer
QGIS/src/app/layers/qgsapplayerhandling.cpp
Line 187 in fb501d5
Note 2: The layer has to be readded into the project for qgis to apply the default behaviour.
Funded by: Klimadatastyrelsen