Flip axes of the 3D world coordinates #59272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally we can stop using the weird convention in 3D views (where X grows to the east, Z grows to the south, Y goes up) that caused endless trouble having to keep in mind that the coordinates in 3D views are rotated compared to the map coordinates. I am not sure anymore why I chose to use this convention, but most likely because Qt's plane mesh is oriented this way (and also various other 3D software has scene with Y going up). Anyway, the world coordinates are not flipped anymore, so the axes are consistent with the map coordinates 🎉 - i.e. X grows to the east, Y grows to the north, Z goes up (well, at least that's the case for many commonly used CRS). The 3D world coordinates are now only translated by the scene's origin point compared to map coordinates.
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
I think |
nyalldawson
approved these changes
Nov 5, 2024
@ptitjano The QgsPoint3DSymbol::transform() still uses "Y up" convention, but the widget uses "Z up" convention as before, so there should be no change needed, or am I missing something? |
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally we can stop using the weird convention in 3D views (where X grows to the east, Z grows to the south, Y goes up) that caused endless trouble having to keep in mind that the coordinates in 3D views are rotated compared to the map coordinates. I am not sure anymore why I chose to use this convention, but most likely because Qt's plane mesh is oriented this way (and also various other 3D software has scene with Y going up).
Anyway, the world coordinates are not flipped anymore, so the axes are consistent with the map coordinates 🎉 - i.e. X grows to the east, Y grows to the north, Z goes up (well, at least that's the case for many commonly used CRS). The 3D world coordinates are now only translated by the scene's origin point compared to map coordinates.