[fix] Improve ownership handling and documentation for Stacked Diagrams #59123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gacarrillor
added
API
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
approved these changes
Oct 17, 2024
|
@nyalldawson, do you know how to get rid of the error in code layout? |
…tackedDiagramProperties
Add an explicit empty constructor for mDiagramRenderers -- that indicates that you're intentionally NOT copying that field |
… for mDiagramRenderers, indicating that we won't copy that field
…st one (if it exists) in the stacked diagram as a basis for the new single one Before this commit, the stacked diagram properties were taken as a basis, losing valuable diagram settings in the process. Note this reverts commit 2f9a0758b309ef162d6390b7411cba71af3375be
…from the main diagram combobox This helps us to better differentiate between a stacked bars diagram and a stacked diagram (using the diagram name alone was a bit confusing: e.g., Stacked).
|
@nyalldawson, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #58568 (probably the last one in this series)
Improves ownership handling of sub renderers in
QgsStackedDiagramRendererandQgsStackedDiagramPropertiesModel.Adds documentation on ownership transfer when receiving or returning sub renderers.
Other adjustments:
subDiagrambysubDiagramRendererwhen we actually refer to renderers.autofor non-complex types.Diagram typecolumn to names from the main diagram combobox. This helps us to better differentiate between a stacked bars diagram and a stacked diagram (using the diagram name alone was a bit confusing: e.g.,Stacked).