ci/revert-ssh-timeouts #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KShivendu
reviewed
Jan 16, 2025
| @@ -2,5 +2,5 @@ | |||
|
|
|||
| PROJECT_PATH=$(realpath "$(dirname "$0")/..") | |||
|
|
|||
| rsync -e "ssh -o ServerAliveInterval=10 -o ServerAliveCountMax=10" -avP --mkpath\ | |||
| rsync -e "ssh -o ServerAliveInterval=10 -o ServerAliveCountMax=3" -avP --mkpath\ | |||
There was a problem hiding this comment.
I didn't understand. Why are we reverting the original PR and why is this one not reverted?
There was a problem hiding this comment.
Sorry, forgot to add a description. So, since I configured the server we run our benchmarks on to block IPs that constantly try to ssh-login, I thought that maybe we don't need these settings anymore. For rsync I decided to keep it just 'cause rsync is used for some relatively bug files and may benefit from those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.