-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate running benchmarks for all engines #134
Conversation
We can adjust the triggering on a job level by adding conditionals like this:
This will NOT trigger the jobs if the changes ONLY include changes in the specified folders and files. For any other case the jobs will run. Unfortunately I'll have to configure each job like this, so it'll look a bit cumbersome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🙌
I hope this will also expose UI (in /actions
) to manually pick only one particular engine/dataset, right?
Interesting that we can do this. @tellet-q Can we do something like this instead?
Where |
Unfortunately, no. There are no changes in the UI. |
Not exactly like this, but similar, yes.
In this case the job will run ONLY if changes were made in specified folders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to try this, then please give it a shot. Otherwise, it lgtm anyways.
Let's see how this works when merged.
Solves #123
Run *-default experiment for each engine using random-100 or glove-25-angular dataset against single-node deployment. Note that OS and ES have dedicated single-node deployments with reduced memory to fit into default github runner.
The workflow triggers: