Skip to content

Commit

Permalink
Use / for probes instead of /readyz (#114)
Browse files Browse the repository at this point in the history
* Use / for probes instead of /readyz

The new implementation of /readyz does not work well together with how StatefulSets do roll outs and restarts

* Fix test
  • Loading branch information
bashofmann authored Dec 12, 2023
1 parent 7c6496d commit 32e85e4
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 9 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## [qdrant-0.7.2](https://github.com/qdrant/qdrant-helm/tree/qdrant-0.7.2) (2023-12-12)

- Use / for probes instead of /readyz endpoint

## [qdrant-0.7.1](https://github.com/qdrant/qdrant-helm/tree/qdrant-0.7.1) (2023-12-12)

- Update Qdrant to v1.7.1
Expand Down
4 changes: 2 additions & 2 deletions charts/qdrant/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Changelog

## [qdrant-0.7.1](https://github.com/qdrant/qdrant-helm/tree/qdrant-0.7.1) (2023-12-12)
## [qdrant-0.7.2](https://github.com/qdrant/qdrant-helm/tree/qdrant-0.7.2) (2023-12-12)

- Update Qdrant to v1.7.1
- Use / for probes instead of /readyz endpoint
6 changes: 3 additions & 3 deletions charts/qdrant/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ maintainers:
url: https://github.com/qdrant
icon: https://qdrant.github.io/qdrant-helm/logo_with_text.svg
type: application
version: 0.7.1
version: 0.7.2
appVersion: v1.7.1
annotations:
artifacthub.io/category: database
artifacthub.io/changes: |
- kind: added
description: Update Qdrant to v1.7.1
- kind: fixed
description: Use / for probes instead of /readyz endpoint
6 changes: 3 additions & 3 deletions charts/qdrant/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ spec:
{{- end }}
{{- if eq .name "http"}}
httpGet:
path: /livez
path: /
port: {{ .targetPort }}
{{- if and $values.config.service $values.config.service.enable_tls }}
scheme: HTTPS
Expand All @@ -118,7 +118,7 @@ spec:
{{- end }}
{{- if eq .name "http"}}
httpGet:
path: /readyz
path: /
port: {{ .targetPort }}
{{- if and $values.config.service $values.config.service.enable_tls }}
scheme: HTTPS
Expand All @@ -138,7 +138,7 @@ spec:
{{- end }}
{{- if eq .name "http"}}
httpGet:
path: /readyz
path: /
port: {{ .targetPort }}
{{- if and $values.config.service $values.config.service.enable_tls }}
scheme: HTTPS
Expand Down
2 changes: 1 addition & 1 deletion test/qdrant_probes_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ func TestDefaultProbesOnStatefulset(t *testing.T) {
})

require.Empty(t, container.StartupProbe)
require.Equal(t, "/readyz", container.ReadinessProbe.HTTPGet.Path)
require.Equal(t, "/", container.ReadinessProbe.HTTPGet.Path)
require.Empty(t, container.LivenessProbe)
}

0 comments on commit 32e85e4

Please sign in to comment.