improve: Improve progress bar #431
Conversation
| if not os.path.exists(os.path.join(result, model_file)): | ||
| raise FileNotFoundError("Couldn't download model from huggingface") |
There was a problem hiding this comment.
what if any of the other required files is missing?
There was a problem hiding this comment.
As far as I know, the blobs are downloaded first, then its extracted to .onnx and the required files. So if the .onnx exists, then the blobs extracted everything correctly. U can check that by deleting the snapshot folder and try to run the model. The snapshot folder will be extracted again and the .onnx (and other files) will exist.
|
|
||
| if is_cached: | ||
| disable_progress_bars() | ||
| if snapshot_dir.exists() and metadata_file.exists(): |
There was a problem hiding this comment.
if version on hf is different from the one we have locally, then we will hide the progress bar and then we will silently download the updated files
I think we could make a corresponding call to HfApi and check revision and commit hash
There was a problem hiding this comment.
Can u explain it further ? Cuz as far as Andrey's said, he don't want to make a call to HFapi as it requires network. Do u mean that we can call it only while downloading on the first time and add revision to metadata ? And only call it when there;s network ?
There was a problem hiding this comment.
I've added a _get_file_hash function to compute hash for each file and then later on checked with _verify_files_from_metadata if the version changed
There was a problem hiding this comment.
I think it's safe to make this call if local_files_only != True
Problem:
Suggestion:
All Submissions:
New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?New models submission: