This repository has been archived by the owner on Dec 30, 2020. It is now read-only.
expose get_icon_from_buffer #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I was holding off on that until we figured out a way to do that from linux, though I honestly can't remember. Right now your patch is failing on CI due to missing that. I guess we could throw a stub function in the linux code, so it'd at least work on windows? |
|
For Windows and Mac. As far as I can remember, I have already fixed that in context of #22 |
|
Closing as this is exposed on windows (on master) and macos (on the macos branch) right now, still gotta figure something out about linux. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be missing something, but it looks like it was an oversight not to expose the get_icon_from_buffer function through the application?