Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to ensure custom servers.json files merge properly #117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

justinhorner
Copy link

provided more context on the proper way to update a custom servers.json file, so the custom changes will not be overwritten by the default servers.json file
spelling fixes
spelling fix 2
@qdm12
Copy link
Owner

qdm12 commented Dec 26, 2024

First of all thanks for this.

however my view on it is that this should be purely automated. The point of the bind mounted servers.json is so that you can automatically update it and gluetun will use it (merged together with its own built-in data). In case I vanish, gluetun should still work using the updating mechanism in place for example. The idea was never that the user should modify it manually, and I still think that's a bad idea - better to fix/PR-to-fix the updating code instead so it benefits everyone.

Now, this as it is won't be merged; however what I just described might not be obvious and, in that case, please change the documentation to your liking so everyone understands this should not be modified manually.

Why did you modify it manually? 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants