Skip to content

Commit

Permalink
feat(options/wireguard): WIREGUARD_PERSISTENT_KEEPALIVE_INTERVAL
Browse files Browse the repository at this point in the history
  • Loading branch information
@qdm12
qdm12 committed May 2, 2024
1 parent b86fdd1 commit e74f645
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions setup/options/wireguard.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ If using the Wireguard protocol, depending on the provider, the following might
| `WIREGUARD_ALLOWED_IPS` | `0.0.0.0/0,::/0` | CSV of IP address ranges | Wireguard peer allowed ips |
| `WIREGUARD_IMPLEMENTATION` | `auto` | `auto`, `kernelspace` or `userspace` | Wireguard implementation to use |
| `WIREGUARD_MTU` | `1400` | Any positive value up to `65535` | Wireguard MTU |
| `WIREGUARD_PERSISTENT_KEEPALIVE_INTERVAL` | | Any duration, for example `25s` | Wireguard persistent keepalive interval |

4 comments on commit e74f645

@blixten85
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25s should be set to default, imo.

@qdm12
Copy link
Owner Author

@qdm12 qdm12 commented on e74f645 Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? 🤔 Plus that would break a tiny bit retro-compatibility in terms of program behavior.

@qdm12
Copy link
Owner Author

@qdm12 qdm12 commented on e74f645 Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually removing this commit (since this was added after v3.38) and I want to do a v3.38 (late) release for the wiki.
Please create an issue suggesting that change and ideally with at least one reason to do it.

@blixten85
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well i can't really say why, i would like to say it's because it's default but i don't know if it's default or not.
I have 25s in my config from my VPN provider. And your suggestion is 25s so why not default it to 25s?
I have a feeling that it's a whole lot of people who do not have to change that particular setting if it's defaulted to 25s.

Please sign in to comment.