Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/facebroke/PostManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,8 @@ protected void doDelete(HttpServletRequest req, HttpServletResponse res) throws

String on_wall = req.getParameter("on_wall");
String wall_id = req.getParameter("wall_id");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential HTTP Response Splitting [HIGH]

HTTP Response Splitting vulnerabilities occur when un-sanitized user-supplied data is used directly in a HTTP response header. Applications that do not sanitize input containing the characters CR (carriage return, also given by %0d or \r) and LF (line feed, also given by %0a or \n) used in HTTP response headers (such as Cookie:) are primarily at risk. These characters permit attackers to control the headers and body of the current response and make it possible to create additional responses entirely under their control. The ability to construct arbitrary HTTP responses permits a variety of resulting attacks, including: cross-user defacement, web and browser cache poisoning, cross-site scripting and page hijacking.

reshift reference: https://reshift.softwaresecured.com/project/scans/519#issue91193

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential Arbitrary URL Redirection [MODERATE]

The identified application pages and associated parameters can be used to redirect unsuspecting users to any URL. The application should not allow redirection to URLs unrelated to the application. Pages allowing arbitrary URL redirection can potentially be used in phishing or social engineering attacks.

reshift reference: https://reshift.softwaresecured.com/project/scans/519#issue91194


String wall_id2 = req.getParameter("wall_id");

try {

long post_id = Long.parseLong(req.getParameter("post_id"));
Expand Down