Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-working DHT bootstrap nodes #21296

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

stalkerok
Copy link
Contributor

@stalkerok stalkerok commented Sep 4, 2024

router.utorrent.com has been dead for a long time. router.bittorrent.com died about a month or two ago. dht.aelitis.com doesn't work either. It is no longer possible to get DHT nodes from them.
Added router.silotis.us. Only ipv6!

@HanabishiRecca
Copy link
Contributor

  1. Are there any talks about that in utorrent/bittorrent community? I.e. we should be sure that this is not a local/regional block.
  2. Do we have reliable testing methods for that?

@stalkerok
Copy link
Contributor Author

2. Do we have reliable testing methods for that?

I tested the addresses using qBit 5.0.
Create in profile\qBittorrent\config qBittorrent.ini with the following contents

[BitTorrent]
Session\DHTBootstrapNodes="router.bittorrent.com:6881, router.utorrent.com:6881, dht.aelitis.com:6881"

Run qBit.

@HanabishiRecca
Copy link
Contributor

HanabishiRecca commented Sep 7, 2024

I have different results. Tested your setup and all nodes separately.

router.bittorrent.com, router.utorrent.com and dht.aelitis.com all kinda work for me.
Yes, DHT nodes count is low and grows very slowly, but they do not appear to be completely dead.

dht.libtorrent.org and dht.transmissionbt.com are much snappier though and quickly reach 300+ nodes in a couple of minutes.

@stalkerok
Copy link
Contributor Author

Are you sure you got the nodes exactly from those bootstrap domains?
2024-09-09_222828

@HanabishiRecca
Copy link
Contributor

Yes.

image

@stalkerok
Copy link
Contributor Author

Is it definitely a clean install? Just to make sure, could you test dht.libtorrent.org with the wrong port number?
2024-09-09_235043

@HanabishiRecca
Copy link
Contributor

HanabishiRecca commented Sep 9, 2024

Is it definitely a clean install?

No, it's my working client.

Just to make sure, could you test dht.libtorrent.org with the wrong port number?

Hmm, it still manages to get DHT nodes somehow. Despite all transfers stopped.
Could that be DHT network remembered my IP and making incoming connections?

That's why I asked for reliable testing methods. I guess I need to wrap up a new isolated client with incoming ports closed.

@HanabishiRecca
Copy link
Contributor

Yeah, running with closed port prevents bootstrapping (DHT: 0) from any of router.bittorrent.com, router.utorrent.com or dht.aelitis.com.

But it would be good to have an easier method to check their accessibility.

router.utorrent.com has been dead for a long time. router.bittorrent.com died about a month or two ago. dht.aelitis.com doesn't work either. It is no longer possible to get DHT nodes from them.
Added router.silotis.us. Only ipv6!
@stalkerok
Copy link
Contributor Author

stalkerok commented Sep 11, 2024

Added router.silotis.us. Only ipv6!
2024-09-11_134040

@Chocobo1
Copy link
Member

Added router.silotis.us. Only ipv6!

Where does it come from? How can we be sure that it is safe?

@stalkerok
Copy link
Contributor Author

Where does it come from? How can we be sure that it is safe?

I found it from another torrent client, I understand the owner is https://github.com/ssiloti

@Chocobo1 Chocobo1 requested a review from a team September 17, 2024 08:36
@glassez
Copy link
Member

glassez commented Sep 17, 2024

So is it confirmed that such DHT bootstrap nodes are dead and not just inaccessible to some people?

@stalkerok
Copy link
Contributor Author

They don't work for me, either through a VPN or from my home connection.

@sledgehammer999
Copy link
Member

FYI for testing: You gain entrance to the DHT network if you somehow connect to at least one node. Then that node can help you find other ones until you position yourself with the closest nodes to you. This single node can be obtained:

  1. Via a bootstrap node
  2. Via a .torrent file containing DHT node entries
  3. Via another peer which you have connected to via a tracker (or they have connected to you via a tracker) if that peer also participates in the DHT network.
  4. IIRC libtorrent saves some nodes in both the fastresume files and in the session state file. If those nodes are still valid when you reload the files, libtorrent will connect to them.

@HanabishiRecca
Copy link
Contributor

4. IIRC libtorrent saves some nodes

No. At least not configured to do that in qBittorrent. We always start with 0 nodes.

@xavier2k6
Copy link
Member

Add router.bitcomet.com:6881?

@xavier2k6
Copy link
Member

I would also add dht.libtorrent.org:6881

@stalkerok
Copy link
Contributor Author

Add router.bitcomet.com:6881?

I would also add dht.libtorrent.org:6881

They don't work.

@stalkerok
Copy link
Contributor Author

Can this be merged and added to the backport to 5.0?

@xavier2k6
Copy link
Member

Is there any forum/reddit discussions etc. about these DHT nodes being actually dead.....dead??

@stalkerok
Copy link
Contributor Author

stalkerok commented Sep 21, 2024

This is probably not discussed anywhere and users don't know how to test it properly. They connect to the DHT through other sources and don't notice anything. First screenshot: home connection, second: VPN. VPN is ipv4 only.
1
2024-09-21_212723

2
2024-09-21_214617

You can check their working order yourself.

@stalkerok
Copy link
Contributor Author

Can anyone confirm or deny the workability of these addresses by running the correct tests? Or merge the PR.
And maybe change the milestone to 5.0.1?
2024-10-03_230739

@HanabishiRecca
Copy link
Contributor

HanabishiRecca commented Oct 3, 2024

I made a script. Nmap should be installed. Requires root because of nmap -sU.

#!/bin/bash

set -euo pipefail

if ! command -v nmap > /dev/null; then
    echo 'Nmap should be installed!'
    exit 1
fi

if ((EUID != 0)); then
    echo 'Need to be run as root!'
    exit 13
fi

LIST=(
    'dht.libtorrent.org:25401'
    'dht.transmissionbt.com:6881'
    'router.bittorrent.com:6881'
    'router.utorrent.com:6881'
    'dht.aelitis.com:6881'
    'router.bitcomet.com:6881'
    'dht.libtorrent.org:6881'
)

# https://www.bittorrent.org/beps/bep_0005.html#ping
PAYLOAD='d1:ad2:id20:abcdefghij0123456789e1:q4:ping1:t2:aa1:y1:qe'

scan() {
    nmap -sU -oG - "${1%:*}" -p "${1#*:}" --data-string "${PAYLOAD}" 2> /dev/null | grep -q '/open/'
}

for a in "${LIST[@]}"; do
    if scan "${a}"; then
        echo "${a} => WORKING!"
    else
        echo "${a} => DEAD"
    fi
done

My results:

dht.libtorrent.org:25401 => WORKING!
dht.transmissionbt.com:6881 => WORKING!
router.bittorrent.com:6881 => DEAD
router.utorrent.com:6881 => DEAD
dht.aelitis.com:6881 => DEAD
router.bitcomet.com:6881 => DEAD
dht.libtorrent.org:6881 => DEAD

P.S. router.bitcomet.com domain does not even exist.

@thalieht
Copy link
Contributor

thalieht commented Oct 3, 2024

My results:

dht.libtorrent.org:25401 => WORKING!
dht.transmissionbt.com:6881 => WORKING!
router.bittorrent.com:6881 => DEAD
router.utorrent.com:6881 => DEAD
dht.aelitis.com:6881 => DEAD
router.bitcomet.com:6881 => DEAD
dht.libtorrent.org:6881 => DEAD

What i got too when i tested each node individually in qbit ~20 min+ each, no torrents, a few days ago. I didn't say anything because i don't know how reliable this test was.

@Chocobo1
Copy link
Member

Chocobo1 commented Oct 5, 2024

@glassez
This PR seems ready. Any comments?

@glassez
Copy link
Member

glassez commented Oct 5, 2024

@glassez This PR seems ready. Any comments?

I have nothing to say about this. You can continue without my approval.

@Chocobo1 Chocobo1 added this to the 5.1 milestone Oct 5, 2024
@Chocobo1 Chocobo1 merged commit e75bcbe into qbittorrent:master Oct 5, 2024
14 checks passed
@Chocobo1
Copy link
Member

Chocobo1 commented Oct 5, 2024

@stalkerok
Thank you!

@HanabishiRecca
Copy link
Contributor

Forgot to say. I didn't test router.silotis.us:6881 because I don't have IPv6.

@stalkerok stalkerok deleted the bootstrap-nodes branch October 5, 2024 13:35
@NUser2018
Copy link

Hello everyone I switched to qBittorrent some time ago in early September precisely due to the fact that DHT stopped working in uTorrent. And although now I have already transferred everything to qBittorrent and have already got used to it and I probably do not plan to return back to uTorrent. However, I still have uTorrent installed and periodically checked. So, the other day, DHT started working again in uTorrent. So at least one of the nodes that are used for DHT in uTorrent (which I do not know and do not know how to look at and check it in uTorrent) came to life the other day (about which I also met a message from one of the users on one of the torrent trackers, according to him router.utorrent.com It still doesn't work, but router.bittorrent.com suddenly came to life). So in my opinion, it's worth double-checking this again before making the changes discussed here to qBittorrent for everyone already in a public release. Even if something doesn't work for a long time, as this example shows, it can suddenly start working again. Therefore, I personally do not understand, to be honest, why remove something from qBittorrent, even if it does not work now, then at some point it may well work again. How does it interfere if it exists but does not work? Well, it doesn't work and it doesn't work. And if that happens, not all users will be able to figure out how to return what and where manually, and in general, not all users will know about it. Therefore, personally, if I were in the place of those responsible for this, it would be better to double-check everything once again and think again before making such changes and deleting something from the qBittorrent settings for all users by default. Moreover, it cannot be excluded that the situation with the availability of nodes for DHT may differ from one user to another, including depending on the country and/or even a specific provider.

PS: if anything, please excuse me, maybe I don't understand all this enough from a technical point of view, and besides, I don't know English, and I use an online translator to write and read such messages.

@HanabishiRecca
Copy link
Contributor

router.bittorrent.com suddenly came to life

Yeah, that appears to be true.

How does it interfere if it exists but does not work? Well, it doesn't work and it doesn't work.

This change was unnecessary from the start, yes. Noone had strong objections though.

Therefore, personally, if I were in the place of those responsible for this, it would be better to double-check everything once again and think again before making such changes and deleting something from the qBittorrent settings for all users by default.

We always can add it back. Nothing critical here.

@stalkerok
Copy link
Contributor Author

If router.bittorrent.com remains working until 5.1.0 is released, I may add it again.

@NUser2018
Copy link

@HanabishiRecca @stalkerok OK. My task was to write about it here and draw attention to it.

@stalkerok
Copy link
Contributor Author

Two months ago I decided to look for more DHT bootstrap nodes, and I found something. I've been tracking them and they work good. The author of the first one also has a profile on github https://github.com/h4cc

ntp.juliusbeckmann.de:6881
mgts.ivth.ru:57858
sorcerer.leentje.org:49786
libertalia.space:50005
milda.intelib.org:51413

Before 5.1.0 comes out I want to bring back the removed router.utorrent.com:6881, it works good. Is there any point in adding more addresses if they will work just as good? The addresses have been checked for security.

@Chocobo1
Copy link
Member

Before 5.1.0 comes out I want to bring back the removed router.utorrent.com:6881, it works good.

I'm ok with it.

Is there any point in adding more addresses if they will work just as good?

I think not. We should only use sites with reputation and not just any site available on the web. I would actually vote to remove router.silotis.us:6881 since it looks like a personal site and the site has not released any information about itself.

@stalkerok
Copy link
Contributor Author

router.silotis.us:6881 since it looks like a personal site

I suggest ask him about it.

@ssiloti You don't mind using this node?

@ssiloti
Copy link

ssiloti commented Dec 24, 2024

router.silotis.us:6881 since it looks like a personal site
@ssiloti You don't mind using this node?

I spun that server up years ago to bootstrap the IPv6 DHT when support was first added to libtorrent. I wouldn't recommend adding it to qBittorrent. It's on a tiny VPS so it probably can't handle the amount of traffic qBittorrent would send and I make no guarantee it will stay up long term.

@NUser2018
Copy link

NUser2018 commented Dec 26, 2024

Before 5.1.0 comes out I want to bring back the removed router.utorrent.com:6881, it works good.

@stalkerok OK. Great. I support this. That's what I've been talking about since I started participating in this discussion. :)

UPDATE: @stalkerok Are you sure you don't mean router.bittorrent.com namely router.utorrent.com ? For more information, see my separate post a little further today. #21296 (comment)

@NUser2018
Copy link

I think not. We should only use sites with reputation and not just any site available on the web.

@Chocobo1 I agree with that.

@NUser2018
Copy link

NUser2018 commented Dec 26, 2024

Before 5.1.0 comes out I want to bring back the removed router.utorrent.com:6881, it works good.

@stalkerok Are you sure you don't mean router.bittorrent.com namely router.utorrent.com ? Since it was originally discussed here (including with my participation) What you earned router.bittorrent.com And we need to get him back! Or and router.utorrent.com is it working now too!? Please explain in more detail and explain specifically about router.bittorrent.com and router.utorrent.com separately about each one. Since at the moment, after reading the latest messages here, I am afraid that there is some kind of confusion that may lead to an error and it is better to double-check everything again and discuss it further.

@stalkerok
Copy link
Contributor Author

I meant router.bittorrent.com. I saw the mistake, but didn't correct the comment already.

@NUser2018
Copy link

I meant router.bittorrent.com. I saw the mistake, but didn't correct the comment already.

@stalkerok OK. Clear. Thank you for your explanation. But maybe then you'd better fix the mistake in that comment.

@ArcticGems
Copy link

Are these nodes good?? =
arvidn/libtorrent#7809

@stalkerok
Copy link
Contributor Author

just FYI
These addresses still work #21296 (comment)
Also added another new address to libtorrent arvidn/libtorrent#7809 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants