Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TIB terminology service for instrument lookup #983

Conversation

sven1103
Copy link
Contributor

Uses the external TIB terminology service to look up ontologies for instruments.

@sven1103 sven1103 requested a review from a team as a code owner January 16, 2025 10:46
@github-actions github-actions bot added the fix label Jan 16, 2025
@sven1103 sven1103 linked an issue Jan 16, 2025 that may be closed by this pull request
1 task
@sven1103
Copy link
Contributor Author

solves #937

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@Steffengreiner Steffengreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@sven1103 sven1103 merged commit 61db1e8 into main Jan 16, 2025
10 of 11 checks passed
@sven1103 sven1103 deleted the fix/#937-measurement-metadata-registration-does-not-work-for-specific-ontology-terms branch January 16, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measurement metadata registration does not work for specific ontology terms
2 participants