Introduce stepper dialog #934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
|
Steffengreiner
approved these changes
Dec 12, 2024
Comment on lines
+5
to
+11
| /** | ||
| * <b><class short description - 1 Line!></b> | ||
| * | ||
| * <p><More detailed description - When to use, what it solves, etc.></p> | ||
| * | ||
| * @since <version tag> | ||
| */ |
Comment on lines
+30
to
+32
| if (steps.isEmpty()) { | ||
| throw new IllegalArgumentException("Steps cannot be empty"); | ||
| } |
There was a problem hiding this comment.
Does it make sense to allow a list of steps with only one steps here? 🤔
|
|
||
| private final List<String> steps; | ||
|
|
||
| private StepperDisplay(StepperDialog stepperDialog, List<String> stepNames) { |
There was a problem hiding this comment.
Is there a reason, why the stepNames are provided as strings? I would have expected, that the stepnames are extracted from the list of steps contained in the provided stepper dialog 🤔
Comment on lines
+1
to
+2
| # Support for editing Flow views with Copilot | ||
| com.vaadin.experimental.copilotFlow=true |
There was a problem hiding this comment.
What's happening here?
Comment on lines
+1
to
+9
| import { UserConfigFn } from 'vite'; | ||
| import { overrideVaadinConfig } from './vite.generated'; | ||
|
|
||
| const customConfig: UserConfigFn = (env) => ({ | ||
| // Here you can add custom Vite parameters | ||
| // https://vitejs.dev/config/ | ||
| }); | ||
|
|
||
| export default overrideVaadinConfig(customConfig); |
There was a problem hiding this comment.
I think we could think about including the dev.bundle, prod.bundle and vite.config.ts file in the gitignore file, since they have to be rebuilt during development anyway 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stepper dialog (also known as wizard), contains at least two steps that are displayed consecutively to the user and ask them for input. They are usually applied when the user input is more complex, is conditionally chained, or can be separated contextually into logical steps.
This contribution introduces a stepper dialog component, that is easy to build and extend, and simplifies the stepper dialog creation.