Introduce spreadsheet-based sample registration #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1103
changed the title
sven1103
changed the title
…t-component-for-sample-batch-registration-to-xlsx-upload
…mple-batch-registration-to-xlsx-upload' of github.com:qbicsoftware/data-manager-app into feature/#680-move-from-the-spreadsheet-component-for-sample-batch-registration-to-xlsx-upload
…ove-from-the-spreadsheet-component-for-sample-batch-registration-to-xlsx-upload
…t-component-for-sample-batch-registration-to-xlsx-upload
The UploadWithDisplay.java can only contain 1 file. Thus uploaded files was changed to uploaded file.
…mple-batch-registration-to-xlsx-upload' of github.com:qbicsoftware/data-manager-app into feature/#680-move-from-the-spreadsheet-component-for-sample-batch-registration-to-xlsx-upload
…t-component-for-sample-batch-registration-to-xlsx-upload
Co-authored-by: Sven F. <[email protected]>
…dsheet-component-for-sample-batch-registration-to-xlsx-upload' into feature/#680-move-from-the-spreadsheet-component-for-sample-batch-registration-to-xlsx-upload
…mple-batch-registration-to-xlsx-upload' of github.com:qbicsoftware/data-manager-app into feature/#680-move-from-the-spreadsheet-component-for-sample-batch-registration-to-xlsx-upload
|
KochTobi
approved these changes
Oct 15, 2024
KochTobi
deleted the
feature/#680-move-from-the-spreadsheet-component-for-sample-batch-registration-to-xlsx-upload
branch
There was a problem hiding this comment.
@KochTobi Great work!
I have a few points :
- The textbox for Batch name is too long, can we shorten it to less than half of it?
- There should be some space between the text and the button for Download template.
- Can there be a little more spacing between the section headers (Download metadata template, Upload the sample data, Uploaded file) and their sections and also between the sections - Upload the sample data and uploaded file?
- The edit dialog is missing a section header - Upload the sample data
- The error message format should be the same as we have for Measurements. Currently, it shows only what went wrong as the status. The data approved format and design is perfect.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will replace the existing Vaadin spreadsheet component and introduce a XLSX spreadsheet-based approach, similar to what is already supported for measurement metadata management and has been introduced in #803.