Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper text for experimental variable input #802

Conversation

KochTobi
Copy link
Member

@KochTobi KochTobi commented Aug 22, 2024

Solves #738
image

@KochTobi KochTobi requested a review from a team as a code owner August 22, 2024 11:24
Copy link

@Shraddha0903 Shraddha0903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KochTobi The helper text looks good although can we adjust the text to 3 lines only?
I cannot see the placeholder text in this screenshot. We provide placeholder text for examples of the values and how they should be written. Font colour for placeholder text is lighter than body text (Secondary text)
Each time the user adds an extra variable in the dialog, it should show the same example as placeholder text in the text fields.

@KochTobi KochTobi linked an issue Aug 22, 2024 that may be closed by this pull request
@KochTobi
Copy link
Member Author

@KochTobi The helper text looks good although can we adjust the text to 3 lines only?

It is quite some effort to do this and increases complexity. To do this the input field would need to be wider which in turn makes the dialog wider.

I cannot see the placeholder text in this screenshot. We provide placeholder text for examples of the values and how they should be written. Font colour for placeholder text is lighter than body text (Secondary text) Each time the user adds an extra variable in the dialog, it should show the same example as placeholder text in the text fields.

I did not notice them in the draft. They are added now.

Copy link

@Shraddha0903 Shraddha0903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KochTobi Awesome!
It's just that it takes up a lot of space for a single property, was trying to reduce that.

Just one other thing the blue cross at the end of the variable row is not aligned with the text fields, seems to be a little down (maybe coz its blue? 😛) Can we align it with the fields?

Screenshot 2024-08-22 at 15 08 32

@KochTobi
Copy link
Member Author

@KochTobi Awesome! It's just that it takes up a lot of space for a single property, was trying to reduce that.

Just one other thing the blue cross at the end of the variable row is not aligned with the text fields, seems to be a little down (maybe coz its blue? 😛) Can we align it with the fields?

Not easy no :/ The image is perfectly aligned. There is some transparent background inside the icon but changing that would be a lot of effort / I don't know how to easily do that with shipped icons.

Screenshot 2024-08-22 at 15 08 32

@KochTobi
Copy link
Member Author

KochTobi commented Aug 22, 2024

@KochTobi Awesome! It's just that it takes up a lot of space for a single property, was trying to reduce that.
Just one other thing the blue cross at the end of the variable row is not aligned with the text fields, seems to be a little down (maybe coz its blue? 😛) Can we align it with the fields?

Not easy no :/ The image is perfectly aligned. There is some transparent background inside the icon but changing that would be a lot of effort / I don't know how to easily do that with shipped icons.

Screenshot 2024-08-22 at 15 08 32

Ah wait. I understand what you mean. Let me check

EDIT: No not possible. Possible alignments: next to the label Levels or at the bottom.
image
image

Copy link

@Shraddha0903 Shraddha0903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KochTobi I feel we can wait for @Steffengreiner to have a look if it's possible, i.e. to top align the icon with respect to the text box only. If it's not possible or takes a lot of effort then we can move to another solution (for e.g. displaying the option to delete the row on the bottom of each row)

Copy link

sonarcloud bot commented Sep 3, 2024

Copy link

@Shraddha0903 Shraddha0903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KochTobi Nicee job! I think it looks good now. 👍

@KochTobi KochTobi merged commit 731ef19 into development Sep 3, 2024
4 checks passed
@KochTobi KochTobi deleted the feature-738/738-add-information-on-how-to-enter-experimental-variables branch September 3, 2024 09:22
KochTobi added a commit that referenced this pull request Sep 3, 2024
* Add helper text

* Add placeholders

* Fix alignment of delete icon in ExperimentalVariableRowLayout

---------

Co-authored-by: Sven F. <[email protected]>
Co-authored-by: Steffengreiner <[email protected]>
Co-authored-by: Steffengreiner <[email protected]>
@KochTobi KochTobi mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add information on how to enter experimental variables
4 participants