Experimental variables and groups are shown as cards with proper scrolling and size #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove batch view button from batchregistration component * Fix sample grid layout * WIP in progress * Update column width of batch component and remove unnecessary logic in BatchDetailsComponent * Update column width of sample grid and remove unnecessary logic in SampleDetailsComponent * Allow user to filter via organismId while searching for samples in SampleInformationMain * Update CSS to behave similar to MeasurementMain * Move search and download logic into samplemain and remove unnecessary logic and components * Remove unused logger * Make columns resizable, change sample label to name in spreadsheet and freeze action and id column * Reset search field value if page is refreshed due to any reason (project switch etc.)
…label-by-sample-name Replace sample label by sample name
… of collaborators to a project (#707) * Provide specifications in user context to enable filtering by full name user name and orcid * Extend userinfo with optional orcid if provided during registration * Update add collaborator UI to show orcid, full name and filtering of the new values * Overhaul UI and ProjectAccessComponentgrid * Add confirm notification if a project user is to be removed * ƒilter for oidc instead of orcid specifically * Update userinfo to also contain oidc issuer * Show oidc link as specified by orcId and generalize it so multiple oidc could be shown * Update css to use oidc instead of orcid * User to userinformation conversion provides oidc issuer * Extract oidcLogo and oidctype to make it reusable * LoginLayout employs extracted oidc logo * Provide javadocs for OidcLogo and extract duplicate css into singular default value for oidc logo * Move OidcLogo and OidcType into general components and adjust width for user access grid * Adjust enum naming scheme to adhere to programmatic standard * Allow filtering of oidcissuer as well within add collaborator dialog * Don't throw an exception if unknown oidc is provided and seperate setting of Oidc with generation of Info item * Fix measurement spacing * Remove controls if user doesn't have access * Adapt frontend cell and create grid via method instead of modifying it * Remove unnecessary semicolon * Add private final to header object * Employ same Div for selection and showing user info * Update CSS according to SP recommendations --------- Co-authored-by: Tobias Koch <[email protected]>
Steffengreiner
changed the title
|
example for variables
example for groups
example image with longer names
|
Shraddha0903
requested changes
Aug 12, 2024
There was a problem hiding this comment.
The cards look good, and I assume that the scroll direction has also changed now.
Just one point - is the scroll applied to the entire Design experiment view? Because the species, specimen analyte are hidden when the user scrolls down. I feel the scroll should only be applied to the experiment variables/groups tab and not the entire view. So that the species, specimen and analyte would still be visible.
|
Changes are out of date due to development branch reset. See #815 for new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Addressed #743, #744
and provides a zoom out of the application to make it more accessible for smaller screens
Finally updates the data privacy statement to include full name user name and orcid since we show it in the project access component now 🤔