Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help user to choose a valid password in the reset password input #716

Conversation

Steffengreiner
Copy link
Contributor

@Steffengreiner Steffengreiner commented Jul 18, 2024

What was changed
Introduce current concept of main components and remove vaadin based components from rest password and new password sending components.
Additionally provide binders checking if the provided password and email is valid

wow-such-code and others added 16 commits July 15, 2024 17:07
* Remove batch view button from batchregistration component

* Fix sample grid layout

* WIP in progress

* Update column width of batch component and remove unnecessary logic in BatchDetailsComponent

* Update column width of sample grid and remove unnecessary logic in SampleDetailsComponent

* Allow user to filter via organismId while searching for samples in SampleInformationMain

* Update CSS to behave similar to MeasurementMain

* Move search and download logic into samplemain and remove unnecessary logic and components

* Remove unused logger

* Make columns resizable, change sample label to name in spreadsheet and freeze action and id column

* Reset search field value if page is refreshed due to any reason (project switch etc.)
…label-by-sample-name

Replace sample label by sample name
@Steffengreiner Steffengreiner marked this pull request as ready for review July 19, 2024 09:13
@Steffengreiner Steffengreiner requested a review from a team as a code owner July 19, 2024 09:13
@KochTobi KochTobi changed the title Feature/dm 703 password reset information for user Help user to choose a valid password in the reset password input Jul 25, 2024
KochTobi and others added 4 commits July 26, 2024 09:26
… of collaborators to a project (#707)

* Provide specifications in user context to enable filtering by full name user name and orcid

* Extend userinfo with optional orcid if provided during registration

* Update add collaborator UI to show orcid, full name and filtering of the new values

* Overhaul UI and ProjectAccessComponentgrid

* Add confirm notification if a project user is to be removed

* ƒilter for oidc instead of orcid specifically

* Update userinfo to also contain oidc issuer

* Show oidc link as specified by orcId and generalize it so multiple oidc could be shown

* Update css to use oidc instead of orcid

* User to userinformation conversion provides oidc issuer

* Extract oidcLogo and oidctype to make it reusable

* LoginLayout employs extracted oidc logo

* Provide javadocs for OidcLogo and extract duplicate css into singular default value for oidc logo

* Move OidcLogo and OidcType into general components and adjust width for user access grid

* Adjust enum naming scheme to adhere to programmatic standard

* Allow filtering of oidcissuer as well within add collaborator dialog

* Don't throw an exception if unknown oidc is provided and seperate setting of Oidc with generation of Info item

* Fix measurement spacing

* Remove controls if user doesn't have access

* Adapt frontend cell and create grid via method instead of modifying it

* Remove unnecessary semicolon

* Add private final to header object

* Employ same Div for selection and showing user info

* Update CSS according to SP recommendations

---------

Co-authored-by: Tobias Koch <[email protected]>
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Steffengreiner
Copy link
Contributor Author

Due to the force reset on the dev branch the relevant changes were moved to it's own PR #819 to avoid merge conflicts.

@KochTobi KochTobi deleted the feature/dm-703-password-reset-information-for-user branch October 18, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inform user on reason for password invalidity during password reset
3 participants