Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.25.0 #375

Merged
merged 14 commits into from
Sep 19, 2023
Merged

Release/0.25.0 #375

merged 14 commits into from
Sep 19, 2023

Conversation

Steffengreiner
Copy link
Contributor

No description provided.

wow-such-code and others added 9 commits September 5, 2023 16:59
* use card collection to make variables look similar to groups

* create card-collection that is independent of card type, rework css, remove unecessary classes

* simplify listeners and events

* rename variable level formatter and use it

* rename methods to add listeners

---------

Co-authored-by: Tobias Koch <[email protected]>
* align add-variable dialog with UI of add-group dialog

* remove debugging
After a user has been granted access to a project, they will now get
notified with an email.

The email also contains a link to the project to simplify access for the user.
Since we are going to introduce a different navigation scheme soon, the navbar is obsolete in the project information page, since the progress is only relevant on experiment level.
Introduces a new concept of communication service as a domain concept and the implementation is now part of the infrastructure.
…368)

* create sample batch in openbis, handle transaction, remove single sample registration

* remove unnecessary service, remove test code

* fix java doc

* adapt tests to method changes, add test

* rename methods not to use 'batch' in openBIS context

* introduce constants for default experiment and sample types

* improve error handling

---------

Co-authored-by: Sven F <[email protected]>
* use SampleOrigin to create openBIS samples, add mapping class

* add optional and error handling
* implement add dialog

* remove active

* remove unnecessary field validation from ContactField

* Create projects without any experiment attached

* fix null checks in Contact

* refactor close method

* Address code smells

* Remove method with to many parameters

* add missing java doc

* use fields to re-use common class names

* reuse ProjectInformation class

* rename person reference to contact in tests

* reduce duplication of edit and add project

* Allow user to switch experiments within the project page  (#374)

* Move ExperimentList to ProjectInformationSupport and adapt view and routing

* Replace ExperimentItemCollection.java with a vaadin listbox

* Fix JD

* Replace ProjectId With Context to preserve selected Experiment

* Fix Contact mapping for responsible Person because of null values

---------

Co-authored-by: Tobias Koch <[email protected]>
Co-authored-by: Steffengreiner <[email protected]>
Co-authored-by: Steffengreiner <[email protected]>
@Steffengreiner Steffengreiner requested a review from a team as a code owner September 19, 2023 12:07
Steffengreiner and others added 5 commits September 19, 2023 14:19
* Move css for tag to span.css

* Add whitespace no wrap within tag collection and remove tag logic since it's stored in span.css now

* Add Tooltips and extract variable level generation to its own method

---------

Co-authored-by: wow-such-code <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@wow-such-code wow-such-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Steffengreiner Steffengreiner merged commit 6f3c695 into main Sep 19, 2023
9 of 10 checks passed
@Steffengreiner Steffengreiner deleted the release/0.25.0 branch September 19, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants