-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.25.0 #375
Merged
Merged
Release/0.25.0 #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use card collection to make variables look similar to groups * create card-collection that is independent of card type, rework css, remove unecessary classes * simplify listeners and events * rename variable level formatter and use it * rename methods to add listeners --------- Co-authored-by: Tobias Koch <[email protected]>
* align add-variable dialog with UI of add-group dialog * remove debugging
After a user has been granted access to a project, they will now get notified with an email. The email also contains a link to the project to simplify access for the user.
Since we are going to introduce a different navigation scheme soon, the navbar is obsolete in the project information page, since the progress is only relevant on experiment level.
Introduces a new concept of communication service as a domain concept and the implementation is now part of the infrastructure.
…368) * create sample batch in openbis, handle transaction, remove single sample registration * remove unnecessary service, remove test code * fix java doc * adapt tests to method changes, add test * rename methods not to use 'batch' in openBIS context * introduce constants for default experiment and sample types * improve error handling --------- Co-authored-by: Sven F <[email protected]>
* use SampleOrigin to create openBIS samples, add mapping class * add optional and error handling
* implement add dialog * remove active * remove unnecessary field validation from ContactField * Create projects without any experiment attached * fix null checks in Contact * refactor close method * Address code smells * Remove method with to many parameters * add missing java doc * use fields to re-use common class names * reuse ProjectInformation class * rename person reference to contact in tests * reduce duplication of edit and add project * Allow user to switch experiments within the project page (#374) * Move ExperimentList to ProjectInformationSupport and adapt view and routing * Replace ExperimentItemCollection.java with a vaadin listbox * Fix JD * Replace ProjectId With Context to preserve selected Experiment * Fix Contact mapping for responsible Person because of null values --------- Co-authored-by: Tobias Koch <[email protected]> Co-authored-by: Steffengreiner <[email protected]> Co-authored-by: Steffengreiner <[email protected]>
* Move css for tag to span.css * Add whitespace no wrap within tag collection and remove tag logic since it's stored in span.css now * Add Tooltips and extract variable level generation to its own method --------- Co-authored-by: wow-such-code <[email protected]>
SonarCloud Quality Gate failed. 1 Bug No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
wow-such-code
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.