Batch registration is enqueued propely with jobrunnr #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steffengreiner
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
sven1103
approved these changes
Aug 8, 2023
KochTobi
added a commit
that referenced
this pull request
Aug 8, 2023
* set duration to 3sec and change position (#333) * Introduce editor functionality to show a custom component within the spreadsheet only if user selects the cell. (#335) * WIP increase performance * Fix blinking issue for comboboxes * Add javadoc and fix header row * Fix Dialog loading * Fix rowcount accession and prefilling of cells for validation * Remove unnecessary duplicate unused checks since we already define the value during row addition * WIP fix dialog reload everything else works * Finally fixed! * Remove unused method * replaces red validation borders in spreadsheet by cell highlighting comparable to usual style * Update Javadocs * rename conversion methods * Fix SonarCloud Code Smell * unlock cells after validation * Fix copy past JD fail --------- Co-authored-by: wow-such-code <[email protected]> * Confirm experimental group deletion with the user when editing experimental variables (#334) * clean up code * add double-check confirmation dialog * address inspection warning * extract confirm dialog into new method * Fix typo Co-authored-by: Steffengreiner <[email protected]> * Fix switched JavaDocs Co-authored-by: steffengreiner <[email protected]> --------- Co-authored-by: Steffengreiner <[email protected]> * Inform User that row deletion is not possible if only one row remains in the spreadsheet. (#336) * Ensure user can't delete the last row * Inline method and ensure that the header row is never deleted * Fix typo in notification * Enables multiple experimental group addition (#328) * Save current work progress * Save work * Save work * Enable addition of multiple experimental groups * Reload experimental groups after registration * Enable experimental group edit * Save current work * Save the day * Finish styling * Clean up * More cleanup work * rename methods, extract methods Co-authored-by: steffengreiner <[email protected]> * Add all experimental groups or none Co-authored-by: steffengreiner <[email protected]> * rename method Co-authored-by: steffengreiner <[email protected]> * Exchange group input by existing component * address code review Co-authored-by: steffengreiner <[email protected]> * Add JavaDoc Co-authored-by: steffengreiner <[email protected]> * rename method Co-authored-by: steffengreiner <[email protected]> * address review * address review * remove duplicate css, group css selectors Co-authored-by: steffengreiner <[email protected]> * remove unused css Co-authored-by: steffengreiner <[email protected]> --------- Co-authored-by: Tobias Koch <[email protected]> Co-authored-by: steffengreiner <[email protected]> * Adds prefill option to sample batch registration (#338) * set experiment null on closing of dialog. reload after prefill to make prefill selection after back-button work * Fix reload of cells with prefilled information * Adapt JD * only remove prefill info if it is variable, correctly validate and remove validation errors * Extract reload into singular method * remove unused boolean flags * clear currently selected cell if experiment has changed * implement correct sorting for replicate labels --------- Co-authored-by: Steffengreiner <[email protected]> Co-authored-by: Tobias Koch <[email protected]> * Check if the cells contain valid values before validation (#337) * Check if the cells contain valid values before validation * add bracket missing due to merge --------- Co-authored-by: Tobias Koch <[email protected]> Co-authored-by: wow-such-code <[email protected]> * Batch registration is enqueued propely with jobrunnr (#340) * Fix missing replicate and specify job logging for add sample to batch job * Fix Job scheduling * Allow the user to edit experiment information via dialog (#339) * Provide edit functionality of an experiment * Provide JD and ensure that only valid values land in backend * Remove outdated dialog and propagate experiment creation correctly * Remove unused deletion methods * Remove unused css and update method name * address Code smell * address Code smell * Address code review part 1 * Fix faulty renaming of method * Extract methods from multiline lambda expression during experimentInformationDialog creation * Fix CSS * Propagate Experiment Information to components instead of reloading the page --------- Co-authored-by: Tobias Koch <[email protected]> Co-authored-by: wow-such-code <[email protected]> Co-authored-by: Sven F <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
As of now all the scheduled jobs in jobrunnr for the batch registration were not working properly.
(Check failed jobs on your local jobrunr instance)
This PR ensures that the sampleIds are loaded properly before the batch is registered and fixes the database schema between sampleIds and batchIds.
Also it fixes a minor issue in the spreadsheet if only one biological replicate is in the experiment.
Finally the jobs now have a proper naming schema to make debugging easier