Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(main): implement more efficient way to get player count #396

Merged
merged 2 commits into from
Sep 29, 2023
Merged

optimize(main): implement more efficient way to get player count #396

merged 2 commits into from
Sep 29, 2023

Conversation

EinS4ckZwiebeln
Copy link
Contributor

The old way to get the current player count was inefficient and over-complicated when such easy thing can be done in one line.
I don't think I have to explain any further why this solution is more reasonable in this scenario.

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? Yes
  • Does your code fit the style guidelines? Yes
  • Does your PR fit the contribution guidelines? Yes

@FBFezz
Copy link

FBFezz commented Aug 26, 2023

Seems fine from my test on a localhost

@GhzGarage GhzGarage merged commit 4b407ec into qbcore-framework:main Sep 29, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants