Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locales): add .nl locales #218

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

SjurdVrancken
Copy link
Contributor

Describe Pull request
Added the translations in Dutch (NL) into the locales.

If your PR is to fix an issue mention that issue here

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? [yes] (Be honest)
  • Does your code fit the style guidelines? [yes]
  • Does your PR fit the contribution guidelines? [yes]

Copy link
Contributor

@nick-perry14 nick-perry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot verify the grammatical accuracy of these translations, but threw into google translate and they all generally translate.

That is to say: There's nothing egregious in these translations.

@GhzGarage
Copy link
Member

It's missing the if condition for checking language value

Added the if condition for checking language value
@SjurdVrancken
Copy link
Contributor Author

It's missing the if condition for checking language value

Fixed

@GhzGarage GhzGarage merged commit 8d715a5 into qbcore-framework:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants