Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve declarations and Assignments #122

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Improve declarations and Assignments #122

merged 3 commits into from
Jul 29, 2024

Conversation

TheGupta2012
Copy link
Member

@TheGupta2012 TheGupta2012 commented Jul 24, 2024 •
edited
Loading

Fixess #90

Changes

  • Add support for the array declarations
  • Update the array indexing to mimic pythonic arrays
  • Improve constant assignments
  • Handle implicit Type casting

@TheGupta2012 TheGupta2012 requested a review from ryanhill1 July 24, 2024 09:21
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.13084% with 2 lines in your changes missing coverage. Please review.

Files Patch % Lines
qbraid_qir/qasm3/oq3_maps.py 89.47% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@TheGupta2012 TheGupta2012 force-pushed the improve-decl-assign branch 2 times, most recently from e802888 to 2466f27 Compare July 24, 2024 12:06
ryanhill1
ryanhill1 requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@ryanhill1 ryanhill1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just the one format update. Opening a separate issue related to the typing thing to move to the built-in collection types instead of using typing

qbraid_qir/qasm3/visitor.py Outdated Show resolved Hide resolved
tests/qasm3_qir/fixtures/variables.py Outdated Show resolved Hide resolved
@TheGupta2012
Copy link
Member Author

Thanks! I'll incorporate these changes and keep on working on the other sub-tasks

@TheGupta2012 TheGupta2012 force-pushed the improve-decl-assign branch from 2466f27 to fa2459a Compare July 24, 2024 14:31
@TheGupta2012 TheGupta2012 marked this pull request as ready for review July 26, 2024 08:34
ryanhill1
ryanhill1 requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@ryanhill1 ryanhill1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you just fix the merge conflicts with main?

@TheGupta2012 TheGupta2012 force-pushed the improve-decl-assign branch from 0ea4f5a to f192347 Compare July 29, 2024 05:38
@TheGupta2012 TheGupta2012 requested a review from ryanhill1 July 29, 2024 05:50
@ryanhill1 ryanhill1 merged commit 0aba78f into main Jul 29, 2024
8 checks passed
@ryanhill1 ryanhill1 deleted the improve-decl-assign branch October 18, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhill1 ryanhill1 ryanhill1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheGupta2012 @ryanhill1