Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pre-release.yml for multi-platform builds #99

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

TheGupta2012
Copy link
Member

Summary of changes

  • Added platform specific builds in pre-release.yaml
  • Updated the pre_build.sh script to detect whether we are in pre-release, if yes, then change the version of the toml file to dev version.
  • Updated the CIBW_BEFORE_BUILD command to include the project name as an argument.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@ryanhill1 ryanhill1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these updates, we no longer need the create_dev_build.sh script, right?

.github/workflows/pre-release.yml Outdated Show resolved Hide resolved
bin/cibw/pre_build.sh Outdated Show resolved Hide resolved
@TheGupta2012
Copy link
Member Author

Yea, idts that the script would be needed.

The only thing which is unclear to me is how the pre-release version numbers would be tracked. For instance, say we have published v0.1.0-a1. Once we trigger the pre-release flow, how will it know that the next version to be published is v0.1.0-a2 if the toml version stays at v0.1.0-alpha?

@ryanhill1
Copy link
Member

@TheGupta2012 It does so using qbraid_core.system.versions.get_latest_package_version() with the option prerelease=True. This function makes a GET request to PyPI, and gets back a list of all of the releases for the given package, and is used as a helper within qbraid_core.system.versions.get_prerelease_version(). And then if the pyproject.toml version ends in -alpha, we get that latest "alpha" release matching that version and bump it by one. Same thing for "beta" and "rc". Or if no pre-releases for that marker exist yet, we set it to 0.

ryanhill1
ryanhill1 previously approved these changes Dec 4, 2024
@TheGupta2012
Copy link
Member Author

@ryanhill1 have also added the change for sdist version bump

@TheGupta2012 TheGupta2012 merged commit a84922e into main Dec 5, 2024
20 checks passed
@TheGupta2012 TheGupta2012 deleted the fix-pre-release branch February 12, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants