-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linalg bug fix & cython integration #83
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
I like the idea here and the speed up is pretty good! Going forward, do you think it would be better to arrange the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the changes
Summary of changes
so_bidiagonalize
kronecker_fator
function to Cython (~60% speedup)so4_to_so2
function to Cython (~5% speedup)kak_decomposition_angles
, if we wanted to.