-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cooper pair box #184
Open
superplay1
wants to merge
6
commits into
q-optimize:dev
Choose a base branch
from
superplay1:CooperPairBox
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cooper pair box #184
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
949c01c
Added class CooperPairBox including static and time-dependent hamilto…
superplay1 44152c0
Added class CooperPairBox including static and time-dependent hamilto…
superplay1 9e84091
Merge branch 'dev' into CooperPairBox
superplay1 3c7588a
Added documentation to CooperPairBox
superplay1 a1aa398
fixed Graph Problem with for loop
superplay1 1d685e5
added test for CooperPairBox
superplay1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will throw an error when "offset_amp" is not in the Envelope parameters. An easy fix would be to add it in the default here: https://github.com/superplay1/c3/blob/1d685e5d8daf73640898040ee5b3ab8bcce02695/c3/signal/pulse.py#L47-L54