Decode PHP strings to prevent slashes in output #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decode PHP strings, so in the final JSON e.g. __('Don\'t') becomes
"Don't" instead of "Don\\'t"
q--
pushed a commit
that referenced
this pull request
Feb 27, 2024
…tion auto-translate value instead of key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to add all relevant features and bugfixes to my own fork, as they don't really make sense to combine into a single PR back to upstream and I don't know when upstream will merge the multiple PRs.
The upstream PR for this bug is joedixon#296
Decode PHP strings, so in the final JSON; e.g.
__('Don\'t')becomes"Don't"instead of"Don\\'t"Steps to reproduce:
Blade file
Run
php artisan translation:sync-missing-translation-keysHow laravel-translation stores it in
<language>.jsonafter running that:What it should be storing: