-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: improve pet_fdg and pet_ftm derivatives #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuguetn
requested changes
Feb 4, 2025
Co-authored-by: Jordi Huguet <[email protected]>
Co-authored-by: Jordi Huguet <[email protected]>
jhuguetn
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requests addressed, PR is good to go. Thanks for your contribution @anaharrismatnez!
jhuguetn
added a commit
that referenced
this pull request
Feb 4, 2025
* ENH: enhancement of fdg and ftm resource functions * REF: simplify landau_signature to return a single quantification value * TEST: add tests for PET regional_quantification (FTM & FDG) --------- Co-authored-by: Jordi Huguet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
regional_quantification()
method for simplified retrieval of regional PET quantification data. It also refactors and improves some of the existingpet_fdg
andpet_ftm
derivative methods.This PR also makes pet-related derivative methods available to FDG_QUANTIFICATION2 and FTM_QUANTIFICATION2 resources.