ISCCP-NG level 1g reader #3002
Open
ISCCP-NG level 1g reader #3002
+536
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sun zenith angles only contains one layer of data.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3002 +/- ##
========================================
Coverage 96.08% 96.09%
========================================
Files 377 379 +2
Lines 55155 55255 +100
========================================
+ Hits 52997 53097 +100
Misses 2158 2158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12083858536Details
💛 - Coveralls |
mraspaud
reviewed
Jan 7, 2025
| def get_dataset(self, key, yaml_info): | ||
| """Get dataset.""" | ||
| logger.debug("Getting data for: %s", yaml_info["name"]) | ||
| nc = xr.open_dataset(self.filename, chunks={"y": CHUNK_SIZE, "x": 800}) |
There was a problem hiding this comment.
Instead of using the legacy chunk size, how about using auto?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reader for the ISCCP-NG L1g format https://cimss.ssec.wisc.edu/isccp-ng/. Nominal calibration us used for SEVIRI. It might be good to recalibrate SEVIRI. But I can not find information in the file on the coefficients used. So these would need to be supplied separately.