Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of EUMETSAT IASI-NG reader #2879

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

roche-emmanuel
Copy link
Contributor

@roche-emmanuel roche-emmanuel commented Aug 9, 2024

This PR introduces the initial implementation of the IASI-NG reader for Satpy.

The changes provided here are self-contained in three files:

  • satpy/readers/iasi_ng_l2_nc.py: The implementation file for the reader.
  • satpy/etc/readers/iasi_ng_l2_nc.yaml: The YAML configuration file for the reader.
  • satpy/tests/reader_tests/test_iasi_ng_l2_nc.py: The unit tests for the reader.

There are still a few points I need to address (this list may be extended progressively):

  • Check support for products with two-letter names (O3_ and CO_), as I don't think they will pass the current file pattern.
  • Confirm with the EUMETSAT team whether the processing logic needs to be adjusted (awaiting clarification on some points concerning the product file specs).
  • Extend the unit tests to perform more comprehensive checks on different products (currently only testing with TWV).
  • Clean the code and remove debug outputs (e.g., print(...) statements).
  • Clarify what needs to be done/added concerning the documentation of this reader.
  • Add my name to the AUTHORS.md file.

The idea here is to start this PR early in the development phase to get early feedback and review notes from you, ensuring we are on the right track for eventual PR acceptance.

If you have any feedback on this PR already, please let me know 😊! In the meantime, I will continue working on the points mentioned above and will provide additional details on the changes as they are made on the feature branch.

Thanks for your help 🙏!

@roche-emmanuel
Copy link
Contributor Author

Alright, so I see from the workflows above that there are some failures due to the formatting of the file, I should maybe start with this before moving forward with the remaining code changes 😉.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 98.36735% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.09%. Comparing base (9e3b342) to head (c1303f3).
Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
satpy/readers/iasi_ng_l2_nc.py 96.35% 7 Missing ⚠️
satpy/tests/reader_tests/test_iasi_ng_l2_nc.py 99.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
+ Coverage   96.06%   96.09%   +0.02%     
==========================================
  Files         373      375       +2     
  Lines       54465    54952     +487     
==========================================
+ Hits        52321    52805     +484     
- Misses       2144     2147       +3     
Flag Coverage Δ
behaviourtests 3.95% <0.00%> (-0.04%) ⬇️
unittests 96.18% <98.36%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Aug 30, 2024

Pull Request Test Coverage Report for Build 11174487208

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 484 of 492 (98.37%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 96.188%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/tests/reader_tests/test_iasi_ng_l2_nc.py 298 299 99.67%
satpy/readers/iasi_ng_l2_nc.py 186 193 96.37%
Files with Coverage Reduction New Missed Lines %
satpy/readers/msi_safe.py 4 98.41%
Totals Coverage Status
Change from base Build 10957325874: 0.02%
Covered Lines: 53041
Relevant Lines: 55143

💛 - Coveralls

@roche-emmanuel roche-emmanuel marked this pull request as ready for review October 9, 2024 06:25
@roche-emmanuel
Copy link
Contributor Author

Hi everyone,

We now think that this MR is ready for a review by the Satpy team, so please let me know if you have any feedback on it. Thanks 😉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants