Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a spline interpolator for 2d arrays #85

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mraspaud
Copy link
Member

This PR adds a spline interpolator based on scipy's RectBivariate spline, which is much faster than the existing grid interpolator based on the RegularGrid interpolator, but cannot extrapolate.

  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@mraspaud mraspaud self-assigned this Oct 10, 2024
@mraspaud mraspaud requested a review from djhoese October 10, 2024 19:41
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 99.03846% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.43%. Comparing base (f151c94) to head (ffc1628).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
geotiepoints/interpolator.py 97.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   87.94%   88.43%   +0.48%     
==========================================
  Files          20       20              
  Lines        1452     1522      +70     
==========================================
+ Hits         1277     1346      +69     
- Misses        175      176       +1     
Flag Coverage Δ
unittests 88.43% <99.03%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 87.725% (+0.5%) from 87.233%
when pulling ffc1628 on mraspaud:add-spline-interpolation
into 5f44745 on pytroll:main.

mraspaud added a commit to mraspaud/satpy that referenced this pull request Oct 11, 2024
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe I would have done some of the subclassing things a little different, but I don't feel strongly enough to spend the time to suggest something that would ultimately be equivalent. Looks good to me.

@mraspaud mraspaud merged commit 11ba92f into pytroll:main Oct 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants