Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing noexcept on cython function #60

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 16, 2023

Removes warnings from cython during building

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@djhoese djhoese added the bug label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #60 (57f4ae3) into main (2944321) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files          21       21           
  Lines        1434     1434           
=======================================
  Hits         1263     1263           
  Misses        171      171           
Flag Coverage Δ
unittests 88.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
geotiepoints/_simple_modis_interpolator.pyx 100.00% <ø> (ø)

@coveralls
Copy link

coveralls commented Oct 16, 2023

Coverage Status

coverage: 87.219%. first build when pulling 57f4ae3 on djhoese:bugfix-cython-perf-warnings into 2944321 on pytroll:main.

@djhoese djhoese merged commit 7c26084 into pytroll:main Oct 16, 2023
17 checks passed
@djhoese djhoese deleted the bugfix-cython-perf-warnings branch October 16, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants