Add manual opcheck tests for roi ops #8144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
Dec 5, 2023
| } | ||
| } | ||
| } | ||
| "data": {} |
There was a problem hiding this comment.
This file still needs to exist even if it's empty, unfortunately.
NicolasHug
commented
Dec 5, 2023
| @@ -610,15 +610,6 @@ def test_jit_boxes_list(self): | |||
| self._helper_jit_boxes_list(model) | |||
|
|
|||
|
|
|||
| optests.generate_opcheck_tests( | |||
| testcase=TestRoIAlign, | |||
There was a problem hiding this comment.
I moved the roi_align opcheck tests to the function below
NicolasHug
commented
Dec 5, 2023
| @@ -676,6 +667,43 @@ def test_boxes_shape(self): | |||
| self._helper_boxes_shape(ops.ps_roi_align) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
This could be in RoIOpTester as a base test, but I personally find it really hard to figure out what is being tested with such inheritance structure. So I'm opting for a self-contained parametrized test here.
(The test inheritance structure predates the adoption of pytest.)
6 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
Reviewed By: vmoens Differential Revision: D52539014 fbshipit-source-id: 6fc2eb107216f1c3933e199a75dc51e620d7c093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8055 and specitically addresses #8055 (comment)
cc @pmeier