-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRANS, IMP] Add new max_size parameter to Resize #3494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3494 +/- ##
==========================================
+ Coverage 78.65% 78.76% +0.10%
==========================================
Files 105 105
Lines 9723 9723
Branches 1557 1561 +4
==========================================
+ Hits 7648 7658 +10
+ Misses 1583 1575 -8
+ Partials 492 490 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Summary: * WIP, still needs tests and docs * tests * flake8 * Docs + fixed some tests * proper error messages Reviewed By: NicolasHug, cpuhrsch Differential Revision: D26945732 fbshipit-source-id: 765c48af203ba27894881dea596f94d2f4a6794d
Addresses (part of) #2868
This PR adds a new
max_size
parameter toResize
. If the size of the resized image is greater thanmax_size
, than the image is resized again to fit withinmax_size
. This is similar to Detectron2's https://github.com/facebookresearch/detectron2/blob/911b091c23a29c624606475d6a2f345568d79e52/detectron2/data/transforms/augmentation_impl.py#L122