-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve example by adding missing import #3051
base: main
Are you sure you want to change the base?
Conversation
The example "Creating a Custom Dataset for your files" was missing the import `from torch.utils.data import Dataset`. Since other imports are shown and the purpose of this example is to show how to create a custom dataset, this import is crucial and should be added.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3051
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @avitase! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@@ -120,6 +120,7 @@ | |||
|
|||
import os | |||
import pandas as pd | |||
from torch.utils.data import Dataset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already imported on line 49:
from torch.utils.data import Dataset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. Still, I was first confused after reading only this section of the doc. Ultimately, it is not a huge deal but at least I would have wished to have this import next to the example.
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Fixes #3050
Description
The example "Creating a Custom Dataset for your files" was missing the import
from torch.utils.data import Dataset
. Since other imports are shown and the purpose of this example is to show how to create a custom dataset, this import is crucial and should be added.Checklist
cc @subramen @albanD @jbschlosser