-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dtensor][debug] Creating recipe allowing users to learn how CommDebugMode works and use visual browser #2993
Conversation
…giving access to visual browser
…giving access to visual browser
…giving access to visual browser
…giving access to visual browser
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2993
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 86fbaab with merge base f1c0b8a (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…giving access to visual browser
…giving access to visual browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the recipe! Please see inlined comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! looks good to me!
Mergebot is not configured for this repository. Please use the merge button provided by GitHub. |
Hi @sinhaanshul! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@sinhaanshul can you please sign the CLA? |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Fixes #ISSUE_NUMBER
Description
I created a recipe showing users how to use CommDebugMode to obtain the results they want. In addition, I have embedded an html file so that users can access and use the visual browser here.
Checklist
cc @wconstab @osalpekar @H-Huang @kwen2501