Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dtensor][debug] Creating recipe allowing users to learn how CommDebugMode works and use visual browser #2993

Closed
wants to merge 15 commits into from

Conversation

sinhaanshul
Copy link

@sinhaanshul sinhaanshul commented Aug 5, 2024

Fixes #ISSUE_NUMBER

Description

I created a recipe showing users how to use CommDebugMode to obtain the results they want. In addition, I have embedded an html file so that users can access and use the visual browser here.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @wconstab @osalpekar @H-Huang @kwen2501

Copy link

pytorch-bot bot commented Aug 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2993

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 86fbaab with merge base f1c0b8a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits

recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the recipe! Please see inlined comments

recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
recipes_source/distributed_comm_debug_mode.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! looks good to me!

Copy link

pytorch-bot bot commented Aug 9, 2024

Mergebot is not configured for this repository. Please use the merge button provided by GitHub.

@facebook-github-bot
Copy link
Contributor

Hi @sinhaanshul!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@svekars
Copy link
Contributor

svekars commented Aug 12, 2024

@sinhaanshul can you please sign the CLA?

Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale Stale PRs label Oct 12, 2024
@github-actions github-actions bot closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants