Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fbcode//torchx/runner/test #941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fbcode//torchx/runner/test #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions torchx/runner/test/api_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ def test_status_ui_url(self, json_dumps_mock: MagicMock, _) -> None:
)
app_handle = runner.run(AppDef(app_id, roles=[role]), scheduler="local_dir")
status = none_throws(runner.status(app_handle))
self.assertEquals(resp.ui_url, status.ui_url)
self.assertEqual(resp.ui_url, status.ui_url)

@patch("json.dumps")
def test_status_structured_msg(self, json_dumps_mock: MagicMock, _) -> None:
Expand All @@ -451,7 +451,7 @@ def test_status_structured_msg(self, json_dumps_mock: MagicMock, _) -> None:
)
app_handle = runner.run(AppDef(app_id, roles=[role]), scheduler="local_dir")
status = none_throws(runner.status(app_handle))
self.assertEquals(resp.structured_error_msg, status.structured_error_msg)
self.assertEqual(resp.structured_error_msg, status.structured_error_msg)

def test_wait_unknown_app(self, _) -> None:
with self.get_runner() as runner:
Expand Down
2 changes: 1 addition & 1 deletion torchx/runner/test/config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ def test_load_invalid_runopt(self, _) -> None:
# this makes things super hard to guarantee BC - stale config file will fail
# to run, we don't want that)

self.assertEquals("option_that_exists", cfg.get("s"))
self.assertEqual("option_that_exists", cfg.get("s"))

def test_load_no_section(self) -> None:
cfg = {}
Expand Down
Loading