Resolve run_opts before passing it to the workspace #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48395915 |
Codecov Report
@@ Coverage Diff @@
## main #755 +/- ##
=======================================
Coverage 92.80% 92.80%
=======================================
Files 96 96
Lines 6071 6073 +2
=======================================
+ Hits 5634 5636 +2
Misses 437 437
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This pull request was exported from Phabricator. Differential Revision: D48395915 |
manav-a
added a commit
to manav-a/torchx
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: pytorch#755 We were resolving the default values for runopts during the dryrun call on the scheduler. This made the ops passed to the workspace not have the defaults correctly populated for workspace opts. This change also resolves the runopts in the runner dryrun and scheduler submit apis. Haven't removed the runopts resolution in scheduler dry run here as a lot of other tests broke with it and it seems reasonable to also have runopts resolved for just the scheduler dryrun. The double resolving of runopts for the runner dryrun and scheduler submit cases shouldnt cause any meaningful differences. There is a separate question on whether workspace should also be built during scheduler dryrun but that can be a follow up change. Differential Revision: D48395915 fbshipit-source-id: 7a6cef7667998c6d83886a697138ccb024c453d5
manav-a
force-pushed
the
export-D48395915
branch
from
c037dba
to
6120d8d
Compare
Summary: Pull Request resolved: pytorch#755 We were resolving the default values for runopts during the dryrun call on the scheduler. This made the ops passed to the workspace not have the defaults correctly populated for workspace opts. This change also resolves the runopts in the runner dryrun and scheduler submit apis. Haven't removed the runopts resolution in scheduler dry run here as a lot of other tests broke with it and it seems reasonable to also have runopts resolved for just the scheduler dryrun. The double resolving of runopts for the runner dryrun and scheduler submit cases shouldnt cause any meaningful differences. There is a separate question on whether workspace should also be built during scheduler dryrun but that can be a follow up change. Differential Revision: D48395915 fbshipit-source-id: c076e933fe3b8c64ff1d9a6b68c37815f73ab060
|
This pull request was exported from Phabricator. Differential Revision: D48395915 |
manav-a
force-pushed
the
export-D48395915
branch
from
6120d8d
to
3b59d99
Compare
kurman
reviewed
Aug 16, 2023
kurman
approved these changes
Aug 16, 2023
miqueljubert
pushed a commit
to miqueljubert/torchx
that referenced
this pull request
Aug 17, 2023
…h#755) (pytorch#755)" Summary: Original commit changeset: b3e964613444 Original Phabricator Diff: D48395915 Differential Revision: D48430887 fbshipit-source-id: 3fdbe84652f8ad07083b16724eadbc2aa7e828f0
KPostOffice
pushed a commit
to KPostOffice/torchx
that referenced
this pull request
Sep 7, 2023
…torch#755) Summary: Pull Request resolved: pytorch#755 We were resolving the default values for runopts during the dryrun call on the scheduler. This made the ops passed to the workspace not have the defaults correctly populated for workspace opts. This change also resolves the runopts in the runner dryrun and scheduler submit apis. Haven't removed the runopts resolution in scheduler dry run here as a lot of other tests broke with it and it seems reasonable to also have runopts resolved for just the scheduler dryrun. The double resolving of runopts for the runner dryrun and scheduler submit cases shouldnt cause any meaningful differences. There is a separate question on whether workspace should also be built during scheduler dryrun but that can be a follow up change. Differential Revision: D48395915 fbshipit-source-id: c076e933fe3b8c64ff1d9a6b68c37815f73ab060
MichaelClifford
pushed a commit
to project-codeflare/torchx
that referenced
this pull request
Sep 8, 2023
…torch#755) Summary: Pull Request resolved: pytorch#755 We were resolving the default values for runopts during the dryrun call on the scheduler. This made the ops passed to the workspace not have the defaults correctly populated for workspace opts. This change also resolves the runopts in the runner dryrun and scheduler submit apis. Haven't removed the runopts resolution in scheduler dry run here as a lot of other tests broke with it and it seems reasonable to also have runopts resolved for just the scheduler dryrun. The double resolving of runopts for the runner dryrun and scheduler submit cases shouldnt cause any meaningful differences. There is a separate question on whether workspace should also be built during scheduler dryrun but that can be a follow up change. Differential Revision: D48395915 fbshipit-source-id: c076e933fe3b8c64ff1d9a6b68c37815f73ab060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We were resolving the default values for runopts during the dryrun call on the scheduler. This made the ops passed to the workspace not have the defaults correctly populated for workspace opts. This change also resolves the runopts in the runner dryrun and scheduler submit apis.
Haven't removed the runopts resolution in scheduler dry run here as a lot of other tests broke with it and it seems reasonable to also have runopts resolved for just the scheduler dryrun. The double resolving of runopts for the runner dryrun and scheduler submit cases shouldnt cause any meaningful differences.
There is a separate question on whether workspace should also be built during scheduler dryrun but that can be a follow up change.
Differential Revision: D48395915