Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws inf2 instance type as named resources #1002

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

HanFa
Copy link
Contributor

@HanFa HanFa commented Jan 24, 2025

Add aws inf2 instance to named resources

Test plan:

/Users/hanfange/workspace/torchx/venv/bin/python /Users/hanfange/Applications/PyCharm Professional Edition.app/Contents/plugins/python-ce/helpers/pycharm/_jb_unittest_runner.py --target named_resources_aws_test.NamedResourcesTest.test_aws_inf2 

Ran 1 test in 0.001s

OK

@facebook-github-bot
Copy link
Contributor

Hi @HanFa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2025
@kiukchung
Copy link
Contributor

LGTM thanks for the contribution! could you fix the linter error?

@HanFa
Copy link
Contributor Author

HanFa commented Feb 14, 2025

Thanks @kiukchung , I have updated the PR to fix the linting error. Could we retry the linting?

@HanFa
Copy link
Contributor Author

HanFa commented Feb 19, 2025

Run lintrunner -a to do the linting, could we retry the lint?

Copy link
Contributor

@tonykao8080 tonykao8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@HanFa
Copy link
Contributor Author

HanFa commented Mar 10, 2025

@tonykao8080 could you check if we can merge this change? I don't think the doc build is a related blocker.

@tonykao8080 tonykao8080 merged commit a90627a into pytorch:main Mar 11, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants